From: Kevin Wolf <kwolf@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
avi@redhat.com, qemu-devel@nongnu.org, aurelien@aurel32.net,
hch@lst.de
Subject: Re: [Qemu-devel] [PATCH] Default to cache=writeback
Date: Tue, 01 Jun 2010 14:46:25 +0200 [thread overview]
Message-ID: <4C050121.2040106@redhat.com> (raw)
In-Reply-To: <EDEC336E-DCDE-4F6E-82AD-5CDBE65A6193@suse.de>
Am 01.06.2010 13:31, schrieb Alexander Graf:
>
> On 26.05.2010, at 21:28, Stefan Hajnoczi wrote:
>
>> On Wed, May 26, 2010 at 7:13 PM, Alexander Graf <agraf@suse.de> wrote:
>>> In the previous discussion Anthony brought up the fact that cache=writeback is
>>> safe enough considering data integrity. If so, I don't see a reason not to use
>>> it as default, as it speeds up things a lot.
>>
>> cache=writeback is not a good default for qcow2:
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=572825
>> http://wiki.qemu.org/Features/Qcow2DataIntegrity
>>
>> The actual qcow2 file itself can become corrupted because metadata
>> updates are not ordered or flushed with respect to each other or data.
>> This is more serious than losing data written after the last flush.
>>
>> I believe special case cache= defaults for raw vs qcow2 have been
>> mentioned before but I don't see any code in qemu.git currently that
>> ensures qcow2 is run safely by default.
>
> Well since cache=writethrough is the default, it apparently isn't hit by the issues you mentioned.
>
> Kevin, what's your opinion on this?
To be honest, I can't follow your argumentation. What you're saying is
basically "with the current default of writethrough it works, so it
can't be dangerous to change the default to writeback". Not sure how you
draw this conclusion.
Kevin
next prev parent reply other threads:[~2010-06-01 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 18:13 [Qemu-devel] [PATCH] Default to cache=writeback Alexander Graf
2010-05-26 19:28 ` Stefan Hajnoczi
2010-06-01 11:31 ` Alexander Graf
2010-06-01 12:46 ` Kevin Wolf [this message]
2010-06-01 12:48 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C050121.2040106@redhat.com \
--to=kwolf@redhat.com \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=avi@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).