From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=32914 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OJRZu-0003Jg-EV
	for qemu-devel@nongnu.org; Tue, 01 Jun 2010 09:32:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jan.kiszka@siemens.com>) id 1OJRO0-00089Z-6s
	for qemu-devel@nongnu.org; Tue, 01 Jun 2010 09:20:05 -0400
Received: from goliath.siemens.de ([192.35.17.28]:17187)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jan.kiszka@siemens.com>) id 1OJRNz-00089M-T2
	for qemu-devel@nongnu.org; Tue, 01 Jun 2010 09:20:04 -0400
Message-ID: <4C0508FF.2050000@siemens.com>
Date: Tue, 01 Jun 2010 15:19:59 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <cover.1274612367.git.jan.kiszka@web.de>	<cover.1274612367.git.jan.kiszka@web.de>	<3715da16813f7cdcb7ec023167a84a94e8a37089.1274612367.git.jan.kiszka@web.de>	<m37hmnjfve.fsf@blackfin.pond.sub.org>	<4C021ED5.1080703@redhat.com>	<m3r5ks8okg.fsf@blackfin.pond.sub.org>	<4C038882.3080007@redhat.com>	<m3d3wcrwg7.fsf_-_@blackfin.pond.sub.org>	<20100601100434.380c6ab3@redhat.com>	<4C05068E.4010102@siemens.com>
	<20100601101320.36476ce2@redhat.com>
In-Reply-To: <20100601101320.36476ce2@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social
	device IDs
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Juan Quintela <quintela@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Jan Kiszka <jan.kiszka@web.de>, Gerd Hoffmann <kraxel@redhat.com>, Avi Kivity <avi@redhat.com>

Luiz Capitulino wrote:
> On Tue, 01 Jun 2010 15:09:34 +0200
> Jan Kiszka <jan.kiszka@siemens.com> wrote:
> 
>> Luiz Capitulino wrote:
>>>  Two bugs that might not be related to this thread:
>>>
>>>   * "id" member is not mandatory for the device_add command:
>>>
>>>     { "execute": "device_add", "arguments": { "driver": "e1000" } }
>>>     {"return": {}}
>> Once we enable qtree paths for device_del, this is no longer an issue,
>> devices will remain addressable.
> 
>  Main point is whether "id" is required or not, I think it should be.

And I think it might be recommended but should become mandatory
(specifically not for HMP).

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux