From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58716 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OJRZq-0003LZ-Lk
	for qemu-devel@nongnu.org; Tue, 01 Jun 2010 09:32:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OJRPW-0008QD-4z
	for qemu-devel@nongnu.org; Tue, 01 Jun 2010 09:21:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50940)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OJRPV-0008Pv-Rv
	for qemu-devel@nongnu.org; Tue, 01 Jun 2010 09:21:38 -0400
Message-ID: <4C05095D.1080900@redhat.com>
Date: Tue, 01 Jun 2010 16:21:33 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <cover.1274612367.git.jan.kiszka@web.de>	<cover.1274612367.git.jan.kiszka@web.de>	<3715da16813f7cdcb7ec023167a84a94e8a37089.1274612367.git.jan.kiszka@web.de>	<m37hmnjfve.fsf@blackfin.pond.sub.org>	<4C021ED5.1080703@redhat.com>	<m3r5ks8okg.fsf@blackfin.pond.sub.org>	<4C038882.3080007@redhat.com>	<m3d3wcrwg7.fsf_-_@blackfin.pond.sub.org>	<20100601100434.380c6ab3@redhat.com>	<4C05068E.4010102@siemens.com>
	<20100601101320.36476ce2@redhat.com> <4C0508FF.2050000@siemens.com>
In-Reply-To: <4C0508FF.2050000@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social
	device IDs
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Juan Quintela <quintela@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Jan Kiszka <jan.kiszka@web.de>, Gerd Hoffmann <kraxel@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

On 06/01/2010 04:19 PM, Jan Kiszka wrote:
>
>>   Main point is whether "id" is required or not, I think it should be.
>>      
> And I think it might be recommended but should become mandatory
> (specifically not for HMP).
>    

I agree.  Making id a mandatory argument will just result in clients 
being forced to manufacture unnecessary IDs, which is annoying.

-- 
error compiling committee.c: too many arguments to function