From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36685 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OJWBc-0000qw-T8
	for qemu-devel@nongnu.org; Tue, 01 Jun 2010 14:27:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OJWBb-0005li-TJ
	for qemu-devel@nongnu.org; Tue, 01 Jun 2010 14:27:36 -0400
Received: from mail-iw0-f173.google.com ([209.85.214.173]:33400)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OJWBb-0005lV-Pv
	for qemu-devel@nongnu.org; Tue, 01 Jun 2010 14:27:35 -0400
Received: by iwn41 with SMTP id 41so898200iwn.4
	for <qemu-devel@nongnu.org>; Tue, 01 Jun 2010 11:27:34 -0700 (PDT)
Message-ID: <4C05510D.6040107@codemonkey.ws>
Date: Tue, 01 Jun 2010 13:27:25 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] virtio-serial-bus: fix ports_map allocation
	on	init
References: <a42bfb91257238dc6adb3d0360e488f463490aca.1274261487.git.amit.shah@redhat.com>
In-Reply-To: <a42bfb91257238dc6adb3d0360e488f463490aca.1274261487.git.amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Alon Levy <alevy@redhat.com>, qemu list <qemu-devel@nongnu.org>

On 05/19/2010 04:31 AM, Amit Shah wrote:
> From: Alon Levy<alevy@redhat.com>
>
> Fix for too small allocation to ports_map
>
> Signed-off-by: Alon Levy<alevy@redhat.com>
> Signed-off-by: Amit Shah<amit.shah@redhat.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   hw/virtio-serial-bus.c |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
> index 3ce95e8..7f9d28f 100644
> --- a/hw/virtio-serial-bus.c
> +++ b/hw/virtio-serial-bus.c
> @@ -774,7 +774,8 @@ VirtIODevice *virtio_serial_init(DeviceState *dev, uint32_t max_nr_ports)
>       }
>
>       vser->config.max_nr_ports = max_nr_ports;
> -    vser->ports_map = qemu_mallocz((max_nr_ports + 31) / 32);
> +    vser->ports_map = qemu_mallocz(((max_nr_ports + 31) / 32)
> +        * sizeof(vser->ports_map[0]));
>       /*
>        * Reserve location 0 for a console port for backward compat
>        * (old kernel, new qemu)
>