* [Qemu-devel] [PATCH] check for active_console before using it
@ 2010-05-20 13:23 Gerd Hoffmann
2010-06-01 18:28 ` Anthony Liguori
0 siblings, 1 reply; 3+ messages in thread
From: Gerd Hoffmann @ 2010-05-20 13:23 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Other vga_hw_* functions do the same.
Fixes a segmentation fault. Trigger: boot with -nodefaults,
then connect via vnc.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
console.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/console.c b/console.c
index 7070b1b..4c42b28 100644
--- a/console.c
+++ b/console.c
@@ -167,7 +167,7 @@ void vga_hw_update(void)
void vga_hw_invalidate(void)
{
- if (active_console->hw_invalidate)
+ if (active_console && active_console->hw_invalidate)
active_console->hw_invalidate(active_console->hw);
}
--
1.6.6.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] check for active_console before using it
2010-05-20 13:23 [Qemu-devel] [PATCH] check for active_console before using it Gerd Hoffmann
@ 2010-06-01 18:28 ` Anthony Liguori
0 siblings, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2010-06-01 18:28 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
On 05/20/2010 08:23 AM, Gerd Hoffmann wrote:
> Other vga_hw_* functions do the same.
> Fixes a segmentation fault. Trigger: boot with -nodefaults,
> then connect via vnc.
>
> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> console.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/console.c b/console.c
> index 7070b1b..4c42b28 100644
> --- a/console.c
> +++ b/console.c
> @@ -167,7 +167,7 @@ void vga_hw_update(void)
>
> void vga_hw_invalidate(void)
> {
> - if (active_console->hw_invalidate)
> + if (active_console&& active_console->hw_invalidate)
> active_console->hw_invalidate(active_console->hw);
> }
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] [PATCH] check for active_console before using it
@ 2010-05-18 19:45 Gerd Hoffmann
0 siblings, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2010-05-18 19:45 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Other vga_hw_* functions do the same.
Fixes a segmentation fault. Trigger: boot with -nodefaults,
then connect via vnc.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
console.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/console.c b/console.c
index 7070b1b..4c42b28 100644
--- a/console.c
+++ b/console.c
@@ -167,7 +167,7 @@ void vga_hw_update(void)
void vga_hw_invalidate(void)
{
- if (active_console->hw_invalidate)
+ if (active_console && active_console->hw_invalidate)
active_console->hw_invalidate(active_console->hw);
}
--
1.6.6.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-01 18:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-20 13:23 [Qemu-devel] [PATCH] check for active_console before using it Gerd Hoffmann
2010-06-01 18:28 ` Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2010-05-18 19:45 Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).