From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50111 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OJWVZ-0000ym-Qx
	for qemu-devel@nongnu.org; Tue, 01 Jun 2010 14:48:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OJWHh-00073f-0x
	for qemu-devel@nongnu.org; Tue, 01 Jun 2010 14:33:53 -0400
Received: from mail-gw0-f45.google.com ([74.125.83.45]:41488)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OJWHg-00073Z-TX
	for qemu-devel@nongnu.org; Tue, 01 Jun 2010 14:33:52 -0400
Received: by gwb11 with SMTP id 11so3870561gwb.4
	for <qemu-devel@nongnu.org>; Tue, 01 Jun 2010 11:33:52 -0700 (PDT)
Message-ID: <4C055286.9080207@codemonkey.ws>
Date: Tue, 01 Jun 2010 13:33:42 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/5] vnc: factor out vnc_desktop_resize()
References: <1274804720-518-1-git-send-email-kraxel@redhat.com>
	<1274804720-518-2-git-send-email-kraxel@redhat.com>
In-Reply-To: <1274804720-518-2-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On 05/25/2010 11:25 AM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
>    

Applied all.  Thanks.

Regards,

Anthony Liguori

> ---
>   vnc.c |   24 ++++++++++++++++--------
>   1 files changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/vnc.c b/vnc.c
> index 11ae3e5..aaebe24 100644
> --- a/vnc.c
> +++ b/vnc.c
> @@ -514,6 +514,21 @@ void buffer_append(Buffer *buffer, const void *data, size_t len)
>       buffer->offset += len;
>   }
>
> +static void vnc_desktop_resize(VncState *vs)
> +{
> +    DisplayState *ds = vs->ds;
> +
> +    if (vs->csock == -1 || !vnc_has_feature(vs, VNC_FEATURE_RESIZE)) {
> +        return;
> +    }
> +    vnc_write_u8(vs, VNC_MSG_SERVER_FRAMEBUFFER_UPDATE);
> +    vnc_write_u8(vs, 0);
> +    vnc_write_u16(vs, 1); /* number of rects */
> +    vnc_framebuffer_update(vs, 0, 0, ds_get_width(ds), ds_get_height(ds),
> +                           VNC_ENCODING_DESKTOPRESIZE);
> +    vnc_flush(vs);
> +}
> +
>   static void vnc_dpy_resize(DisplayState *ds)
>   {
>       int size_changed;
> @@ -542,14 +557,7 @@ static void vnc_dpy_resize(DisplayState *ds)
>       QTAILQ_FOREACH(vs,&vd->clients, next) {
>           vnc_colordepth(vs);
>           if (size_changed) {
> -            if (vs->csock != -1&&  vnc_has_feature(vs, VNC_FEATURE_RESIZE)) {
> -                vnc_write_u8(vs, VNC_MSG_SERVER_FRAMEBUFFER_UPDATE);
> -                vnc_write_u8(vs, 0);
> -                vnc_write_u16(vs, 1); /* number of rects */
> -                vnc_framebuffer_update(vs, 0, 0, ds_get_width(ds), ds_get_height(ds),
> -                        VNC_ENCODING_DESKTOPRESIZE);
> -                vnc_flush(vs);
> -            }
> +            vnc_desktop_resize(vs);
>           }
>           if (vs->vd->cursor) {
>               vnc_cursor_define(vs);
>