From: Anthony Liguori <anthony@codemonkey.ws>
To: "Bernhard M. Wiedemann" <qemudevbmw@lsmod.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Extra scan codes for missing keys
Date: Tue, 01 Jun 2010 14:46:18 -0500 [thread overview]
Message-ID: <4C05638A.9060405@codemonkey.ws> (raw)
In-Reply-To: <1275420581-15650-1-git-send-email-qemudevbmw@lsmod.de>
On 06/01/2010 02:29 PM, Bernhard M. Wiedemann wrote:
> The code comes from
> http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02788.html
>
> Without this patch it is not possible to send at least 10 special
> characters (\|'"`~:;[]{}) via the monitor sendkey command.
>
> Signed-off-by: Bernhard M. Wiedemann<qemudevbmw@lsmod.de>
> ---
> monitor.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 15b53b9..09ff8cf 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -1563,6 +1563,8 @@ static const KeyDef key_defs[] = {
> { 0x17, "i" },
> { 0x18, "o" },
> { 0x19, "p" },
> + { 0x1a, "sqr_brack_l" },
> + { 0x1b, "sqr_brack_r" },
>
I think it would be better to spell it out as: bracket_left and
bracket_right
Regards,
Anthony Liguori
>
> { 0x1c, "ret" },
>
> @@ -1575,7 +1577,11 @@ static const KeyDef key_defs[] = {
> { 0x24, "j" },
> { 0x25, "k" },
> { 0x26, "l" },
> + { 0x27, "semicolon" },
> + { 0x28, "apostrophe" },
> + { 0x29, "grave_accent" },
>
> + { 0x2b, "backslash" },
> { 0x2c, "z" },
> { 0x2d, "x" },
> { 0x2e, "c" },
>
next prev parent reply other threads:[~2010-06-01 19:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 20:31 [Qemu-devel] [PATCH] Extra scan codes for missing keys Brendan Sleight
2010-06-01 19:29 ` Bernhard M. Wiedemann
2010-06-01 19:46 ` Anthony Liguori [this message]
2010-06-02 3:32 ` Bernhard M. Wiedemann
2010-06-23 1:46 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C05638A.9060405@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=qemudevbmw@lsmod.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).