From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44018 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OJXPx-0003DW-3G
	for qemu-devel@nongnu.org; Tue, 01 Jun 2010 15:46:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OJXPv-0001gI-Ku
	for qemu-devel@nongnu.org; Tue, 01 Jun 2010 15:46:28 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:36787)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OJXPv-0001fl-IM
	for qemu-devel@nongnu.org; Tue, 01 Jun 2010 15:46:27 -0400
Received: by yxk8 with SMTP id 8so144013yxk.4
	for <qemu-devel@nongnu.org>; Tue, 01 Jun 2010 12:46:26 -0700 (PDT)
Message-ID: <4C05638A.9060405@codemonkey.ws>
Date: Tue, 01 Jun 2010 14:46:18 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Extra scan codes for missing keys
References: <AANLkTinxyNqLfXD6D_2b1iZ7CSPeZZtPpVE7KHnt0J5p@mail.gmail.com>
	<1275420581-15650-1-git-send-email-qemudevbmw@lsmod.de>
In-Reply-To: <1275420581-15650-1-git-send-email-qemudevbmw@lsmod.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Bernhard M. Wiedemann" <qemudevbmw@lsmod.de>
Cc: qemu-devel@nongnu.org

On 06/01/2010 02:29 PM, Bernhard M. Wiedemann wrote:
> The code comes from
> http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02788.html
>
> Without this patch it is not possible to send at least 10 special
> characters (\|'"`~:;[]{}) via the monitor sendkey command.
>
> Signed-off-by: Bernhard M. Wiedemann<qemudevbmw@lsmod.de>
> ---
>   monitor.c |    6 ++++++
>   1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 15b53b9..09ff8cf 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -1563,6 +1563,8 @@ static const KeyDef key_defs[] = {
>       { 0x17, "i" },
>       { 0x18, "o" },
>       { 0x19, "p" },
> +    { 0x1a, "sqr_brack_l" },
> +    { 0x1b, "sqr_brack_r" },
>    

I think it would be better to spell it out as: bracket_left and 
bracket_right

Regards,

Anthony Liguori

>
>       { 0x1c, "ret" },
>
> @@ -1575,7 +1577,11 @@ static const KeyDef key_defs[] = {
>       { 0x24, "j" },
>       { 0x25, "k" },
>       { 0x26, "l" },
> +    { 0x27, "semicolon" },
> +    { 0x28, "apostrophe" },
> +    { 0x29, "grave_accent" },
>
> +    { 0x2b, "backslash" },
>       { 0x2c, "z" },
>       { 0x2d, "x" },
>       { 0x2e, "c" },
>