From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56935 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OJhlY-000083-PO for qemu-devel@nongnu.org; Wed, 02 Jun 2010 02:49:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OJhlU-0007Hq-9j for qemu-devel@nongnu.org; Wed, 02 Jun 2010 02:49:28 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:44610) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJhlT-0007Hc-Rx for qemu-devel@nongnu.org; Wed, 02 Jun 2010 02:49:24 -0400 Message-ID: <4C05FEEA.20909@web.de> Date: Wed, 02 Jun 2010 08:49:14 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4C05479E.3010705@siemens.com> <4C056F16.8000906@cs.vu.nl> In-Reply-To: <4C056F16.8000906@cs.vu.nl> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig29C956848C79664098EF6B1A" Sender: jan.kiszka@web.de Subject: [Qemu-devel] [PATCH v2] x86: svm: Always clear event_inj on vmexit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Erik van der Kouwe Cc: Joerg Roedel , qemu-devel , Gleb Natapov This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig29C956848C79664098EF6B1A Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Erik van der Kouwe wrote: > Hi, >=20 >> We currently only clear SVM_EVTINJ_VALID after successful interrupt >> delivery. This apparently does not match real hardware which clears th= e >> whole event_inj field on every vmexit, including unsuccessful interrup= t >> delivery. >=20 > Thanks for the patch. It is a bit hard for me to test right now as I > messed up my test setup, but I will do so ASAP and let you know. >=20 > However, I'm worried that this patch may introduce a new problem (I may= > be mistaken though). There is still this code to load the exit interrup= t > info: >=20 > stl_phys(env->vm_vmcb + offsetof(struct vmcb, > control.exit_int_info_err), > ldl_phys(env->vm_vmcb + offsetof(struct vmcb, > control.event_inj_err))); >=20 > Now that event_inj is no longer loaded, won't this mean that > exit_int_info and exit_int_info_err also won't be loaded? Sorry, can't follow this ATM. But maybe you mean this: there is indeed a problem with removing the clearance of event_inj.invalid as it may be later on transferred into exit_int_info. And if we succeed with injecting the event, that field must not remaind valid. OK, here is v2: -------> From: Jan Kiszka We currently only clear SVM_EVTINJ_VALID after successful interrupt delivery. This apparently does not match real hardware which clears the whole event_inj field on every vmexit, including unsuccessful interrupt delivery. Reported-by: Erik van der Kouwe Signed-off-by: Jan Kiszka --- target-i386/op_helper.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c index dcbdfe7..52e8910 100644 --- a/target-i386/op_helper.c +++ b/target-i386/op_helper.c @@ -5388,6 +5388,7 @@ void helper_vmexit(uint32_t exit_code, uint64_t exi= t_info_1) ldl_phys(env->vm_vmcb + offsetof(struct vmcb, control.event= _inj))); stl_phys(env->vm_vmcb + offsetof(struct vmcb, control.exit_int_info_= err), ldl_phys(env->vm_vmcb + offsetof(struct vmcb, control.event= _inj_err))); + stl_phys(env->vm_vmcb + offsetof(struct vmcb, control.event_inj), 0)= ; =20 env->hflags2 &=3D ~HF2_GIF_MASK; /* FIXME: Resets the current ASID register to zero (host ASID). */ --=20 1.6.0.2 --------------enig29C956848C79664098EF6B1A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkwF/vAACgkQitSsb3rl5xSs5QCgu3EUgNCiSAbVDQNqAUkg/e7v LfcAn14adAYQjC3OQ0JpSME666s0bufB =rFHI -----END PGP SIGNATURE----- --------------enig29C956848C79664098EF6B1A--