From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49600 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OJl1I-0004s1-BI for qemu-devel@nongnu.org; Wed, 02 Jun 2010 06:17:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OJl1G-0002Az-MS for qemu-devel@nongnu.org; Wed, 02 Jun 2010 06:17:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41766) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJl1G-0002Ak-F5 for qemu-devel@nongnu.org; Wed, 02 Jun 2010 06:17:54 -0400 Message-ID: <4C062FBD.2010701@redhat.com> Date: Wed, 02 Jun 2010 12:17:33 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] vnc: split encoding in specific files References: <1272889894-17734-1-git-send-email-corentincj@iksaif.net> <4BDF04CB.90104@codemonkey.ws> <4BDFD6FA.7030200@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corentin Chary Cc: qemu-devel@nongnu.org, Alexander Graf Am 02.06.2010 12:06, schrieb Corentin Chary: > On Tue, May 4, 2010 at 10:12 AM, Kevin Wolf wrote: >> Am 03.05.2010 19:15, schrieb Anthony Liguori: >>> On 05/03/2010 07:31 AM, Corentin Chary wrote: >>>> This will allow to implement new encodings (tight, zrle, ..) >>>> in a cleaner way. This may hurt performances, because some >>>> functions like vnc_convert_pixel are not static anymore, but >>>> should not be a problem with gcc 4.5 and the new -flto. >>>> >>>> Signed-off-by: Corentin Chary >>>> >>> >>> Applied. Thanks. >>> >>> It's probably time to make a vnc directory too. >> >> Or maybe one for all of the interfaces we currently have in the root >> directory? So it would include not only VNC, but also SDL and curses. >> >> Kevin >> > > > vnc-encodnig-tight.c is growing up, and I think I'll split it, again. > So, maybe it's time to move VNC code (and others) to a subdirectory. > > I suggest ui/ . > If it's ok, I'll make the patch. ui/ sounds good. Kevin