From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43783 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OJo1T-0000v2-8J
	for qemu-devel@nongnu.org; Wed, 02 Jun 2010 09:30:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OJo1R-0008W2-Vi
	for qemu-devel@nongnu.org; Wed, 02 Jun 2010 09:30:19 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:37918)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OJo1R-0008Vu-RP
	for qemu-devel@nongnu.org; Wed, 02 Jun 2010 09:30:17 -0400
Received: by gyd5 with SMTP id 5so4643377gyd.4
	for <qemu-devel@nongnu.org>; Wed, 02 Jun 2010 06:30:17 -0700 (PDT)
Message-ID: <4C065CE3.1090609@codemonkey.ws>
Date: Wed, 02 Jun 2010 08:30:11 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC] [PATCH 0/5] Add horizontal wheel support to
	mice, where possible
References: <1272992201-26911-1-git-send-email-anomie@users.sourceforge.net>
In-Reply-To: <1272992201-26911-1-git-send-email-anomie@users.sourceforge.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Brad Jorsch <anomie@users.sourceforge.net>
Cc: qemu-devel@nongnu.org

On 05/04/2010 11:56 AM, Brad Jorsch wrote:
> The emulated mice should emulate a horizontal wheel when possible. This
> patch series does that for the USB mouse and tablet and the ExPS/2
> mouse. As far as I can tell the vmmouse protocol doesn't handle a
> horizontal wheel, and I have no idea if emulating a wheel might make
> sense for any of the other mouse types.
>    

At this point, are we just talking about adding additional mouse buttons?

I think instead of adding an additional parameter for horizontal wheel, 
we should look at making the API capable of accepting/generating 
arbitrary button presses.

Really, we should just drop dz and treat vertical wheel as two button 
presses within button_state.  Likewise, horizontal wheel should just be 
two additional bits within button_state.

Regards,

Anthony Liguori

> I've tested this using the SDL interface and an Ububtu 10.04 cd image;
> xev reports the correct events for all three devices, and a gedit window
> with sufficient text to create scrollbars scrolls correctly with both
> mice (didn't test the tablet). More testing would be good.
>
> See also Debian bug #579968.[1]
>
> [1] http://bugs.debian.org/579968
>
>
>
>