qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 3/3] blockdev: Collect block device code in new blockdev.c
Date: Wed, 02 Jun 2010 17:52:37 +0200	[thread overview]
Message-ID: <4C067E45.1050801@redhat.com> (raw)
In-Reply-To: <1275478317-1989-4-git-send-email-armbru@redhat.com>

Am 02.06.2010 13:31, schrieb Markus Armbruster:
> Anything that moves hundreds of lines out of vl.c can't be all bad.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

New files need a license header, otherwise it looks ok.

I have applied this patch (and the other ones, too) to the block branch
anyway to avoid conflicts with other people basing their patches on that
branch. However, it requires a v2 before I can propose this to be merged
into master.

Kevin

  reply	other threads:[~2010-06-02 15:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-02 11:31 [Qemu-devel] [PATCH 0/3] Collect block device code in new blockdev.c Markus Armbruster
2010-06-02 11:31 ` [Qemu-devel] [PATCH 1/3] blockdev: Hide QEMUMachine from drive_init() Markus Armbruster
2010-06-02 11:31 ` [Qemu-devel] [PATCH 2/3] qdev: Move declaration of qdev_init_bdrv() into qdev.h Markus Armbruster
2010-06-02 11:31 ` [Qemu-devel] [PATCH 3/3] blockdev: Collect block device code in new blockdev.c Markus Armbruster
2010-06-02 15:52   ` Kevin Wolf [this message]
2010-06-02 16:16     ` [Qemu-devel] " Markus Armbruster
2010-06-04 10:43       ` Kevin Wolf
2010-06-04 12:12         ` Markus Armbruster
2010-06-02 16:48   ` [Qemu-devel] [PATCH v2 " Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C067E45.1050801@redhat.com \
    --to=kwolf@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).