From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47910 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OJqFW-0005dE-Li for qemu-devel@nongnu.org; Wed, 02 Jun 2010 11:52:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OJqFV-00035Q-DZ for qemu-devel@nongnu.org; Wed, 02 Jun 2010 11:52:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8869) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJqFV-000355-55 for qemu-devel@nongnu.org; Wed, 02 Jun 2010 11:52:57 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o52FqtEl020387 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 2 Jun 2010 11:52:55 -0400 Message-ID: <4C067E45.1050801@redhat.com> Date: Wed, 02 Jun 2010 17:52:37 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1275478317-1989-1-git-send-email-armbru@redhat.com> <1275478317-1989-4-git-send-email-armbru@redhat.com> In-Reply-To: <1275478317-1989-4-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 3/3] blockdev: Collect block device code in new blockdev.c List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org Am 02.06.2010 13:31, schrieb Markus Armbruster: > Anything that moves hundreds of lines out of vl.c can't be all bad. > > Signed-off-by: Markus Armbruster New files need a license header, otherwise it looks ok. I have applied this patch (and the other ones, too) to the block branch anyway to avoid conflicts with other people basing their patches on that branch. However, it requires a v2 before I can propose this to be merged into master. Kevin