From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47411 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OJtcL-0004sb-AE
	for qemu-devel@nongnu.org; Wed, 02 Jun 2010 15:28:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OJtcK-0001sh-3d
	for qemu-devel@nongnu.org; Wed, 02 Jun 2010 15:28:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37032)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OJtcJ-0001sQ-TW
	for qemu-devel@nongnu.org; Wed, 02 Jun 2010 15:28:44 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o52JSgb6003864
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 2 Jun 2010 15:28:42 -0400
Message-ID: <4C06B0E5.6010603@redhat.com>
Date: Wed, 02 Jun 2010 21:28:37 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1275497729-13120-1-git-send-email-armbru@redhat.com>
	<1275497729-13120-9-git-send-email-armbru@redhat.com>
In-Reply-To: <1275497729-13120-9-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 08/13] qdev: Decouple qdev_prop_drive from
	DriveInfo
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org

   Hi,

> +static void free_drive(DeviceState *dev, Property *prop)
> +{
> +    BlockDriverState **ptr = qdev_get_prop_ptr(dev, prop);
> +
> +    if (*ptr) {
> +        blockdev_detach(*ptr, dev);
> +    }
> +}

> @@ -1043,26 +1043,26 @@ static void scsi_destroy(SCSIDevice *dev)
>       SCSIDiskState *s = DO_UPCAST(SCSIDiskState, qdev, dev);
>
>       scsi_disk_purge_requests(s);
> -    drive_uninit(s->qdev.conf.dinfo);
>   }

Neat.  Commit message should better explain that though.

cheers,
   Gerd