qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, qemu-devel@nongnu.org,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCHv2-RFC 0/2] virtio: put last seen used index	into ring itself
Date: Wed, 02 Jun 2010 22:39:02 +0200	[thread overview]
Message-ID: <4C06C166.3050201@redhat.com> (raw)
In-Reply-To: <201005311716.43573.rusty@rustcorp.com.au>

On 05/31/10 09:46, Rusty Russell wrote:
> On Thu, 27 May 2010 05:20:35 am Michael S. Tsirkin wrote:
>> Here's a rewrite of the original patch with a new layout.
>> I haven't tested it yet so no idea how this performs, but
>> I think this addresses the cache bounce issue raised by Avi.
>> Posting for early flames/comments.
> 
> Sorry, not without some evidence that it'll actually reduce cacheline
> bouncing.  I *think* it will, but it's not obvious: the host may keep
> looking at avail_idx as we're updating last_seen.  Or does qemu always
> look at both together anyway?
> 
> Can someone convince me this is a win?
> Rusty.

Hi Rusty,

I ran some tests using the vring index publish patch with virtio_blk.
The numbers are based on running IOZone on a ramdisk passed to the guest
via virtio. While I didn't see any throughput improvements, I saw a
20-30% reduction in the VMExit count for the full run. This was measured
grabbing the VMExit count prior and after the run and calculating the
difference.

I have the numbers in a PDF, so I will email it to you in private as I
don't like sending PDFs to the mailing list. However if anybody else
wants the numbers feel free to ping me off list and I'll forward them.

Cheers,
Jes

      parent reply	other threads:[~2010-06-02 20:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-26 19:50 [Qemu-devel] [PATCHv2-RFC 0/2] virtio: put last seen used index into ring itself Michael S. Tsirkin
2010-05-26 19:50 ` [Qemu-devel] [PATCHv2-RFC 1/2] virtio: support layout with avail ring before idx Michael S. Tsirkin
2010-05-26 19:50 ` [Qemu-devel] [PATCHv2-RFC 2/2] virtio: publish used idx Michael S. Tsirkin
2010-05-27 12:07 ` [Qemu-devel] Re: [PATCHv2-RFC 0/2] virtio: put last seen used index into ring itself Avi Kivity
2010-05-27 13:59   ` Michael S. Tsirkin
2010-05-28  9:56 ` Jes Sorensen
2010-05-30 11:22   ` Michael S. Tsirkin
2010-05-31  7:36     ` Jes Sorensen
2010-05-31 13:29       ` Michael S. Tsirkin
2010-05-31  7:46 ` Rusty Russell
2010-05-31 12:20   ` Michael S. Tsirkin
2010-06-02 20:39   ` Jes Sorensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C06C166.3050201@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).