From: Paolo Bonzini <pbonzini@redhat.com>
To: Corentin Chary <corentincj@iksaif.net>
Cc: Anthony Liguori <aliguori@linux.vnet.ibm.com>,
Alexander Graf <agraf@suse.de>, Adam Litke <agl@us.ibm.com>,
qemu-devel@nongnu.org, Gautham R Shenoy <ego@in.ibm.com>
Subject: [Qemu-devel] Re: [PATCH 2/3] qemu-thread: add cleanup_push() and cleanup_pop()
Date: Thu, 03 Jun 2010 09:27:00 +0200 [thread overview]
Message-ID: <4C075944.7010001@redhat.com> (raw)
In-Reply-To: <1275118686-15649-3-git-send-email-corentincj@iksaif.net>
On 05/29/2010 09:38 AM, Corentin Chary wrote:
> Signed-off-by: Corentin Chary<corentincj@iksaif.net>
> ---
> qemu-thread.h | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-thread.h b/qemu-thread.h
> index 19bb30c..e5006bb 100644
> --- a/qemu-thread.h
> +++ b/qemu-thread.h
> @@ -41,4 +41,8 @@ void qemu_thread_self(QemuThread *thread);
> int qemu_thread_equal(QemuThread *thread1, QemuThread *thread2);
> void qemu_thread_exit(void *retval);
>
> +#define qemu_thread_cleanup_pop(execute) pthread_cleanup_pop(execute)
> +#define qemu_thread_cleanup_push(routine, arg) \
> + pthread_cleanup_push(routine, arg)
I agree with Paul that this isn't necessary. Also you're not using
pthread_exit. Probably stale from a previous version of the patch?
Paolo
next prev parent reply other threads:[~2010-06-03 7:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-29 7:38 [Qemu-devel] [PATCH 0/3] [RFC] Threaded vnc server Corentin Chary
2010-05-29 7:38 ` [Qemu-devel] [PATCH 1/3] qemu-thread: add qemu_mutex/cond_destroy and qemu_mutex_exit Corentin Chary
2010-05-29 7:38 ` [Qemu-devel] [PATCH 2/3] qemu-thread: add cleanup_push() and cleanup_pop() Corentin Chary
2010-06-03 5:50 ` Paul Brook
2010-06-03 7:27 ` Paolo Bonzini [this message]
2010-06-03 7:46 ` [Qemu-devel] " Corentin Chary
2010-05-29 7:38 ` [Qemu-devel] [PATCH 3/3] vnc: threaded VNC server Corentin Chary
2010-06-03 7:55 ` [Qemu-devel] " Paolo Bonzini
2010-06-03 8:26 ` Corentin Chary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C075944.7010001@redhat.com \
--to=pbonzini@redhat.com \
--cc=agl@us.ibm.com \
--cc=agraf@suse.de \
--cc=aliguori@linux.vnet.ibm.com \
--cc=corentincj@iksaif.net \
--cc=ego@in.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).