From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35085 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OKRiz-0002XK-Fz for qemu-devel@nongnu.org; Fri, 04 Jun 2010 03:53:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OKRiy-0007SD-ER for qemu-devel@nongnu.org; Fri, 04 Jun 2010 03:53:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44047) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OKRiy-0007S2-5a for qemu-devel@nongnu.org; Fri, 04 Jun 2010 03:53:52 -0400 Message-ID: <4C08B109.7090308@redhat.com> Date: Fri, 04 Jun 2010 09:53:45 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20100601200434.5908.19495.stgit@skyserv> <20100601201232.5908.51923.stgit@skyserv> <4C07ABBA.7060909@redhat.com> <2FD51753-A06F-46B2-B813-07C3A6D0D4EA@suse.de> <4C07CD53.3020403@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 3/8] sparc64: fix 32bit load sign extension List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Kovalenko Cc: Blue Swirl , Alexander Graf , "qemu-devel@nongnu.org" On 06/03/2010 09:59 PM, Igor Kovalenko wrote: > On Thu, Jun 3, 2010 at 7:42 PM, Paolo Bonzini wrote: >> On 06/03/2010 05:25 PM, Alexander Graf wrote: >>> >>> Am 03.06.2010 um 15:18 schrieb Paolo Bonzini: >>> >>>> On 06/01/2010 10:12 PM, Igor V. Kovalenko wrote: >>>>> >>>>> From: Igor V. Kovalenko >>>>> >>>>> - change return type of ldl_* to uint32_t to prevent unwanted sign >>>>> extension >>>>> visible in sparc64 load alternate address space methods >>>>> - note this change makes ldl_* softmmu implementations match ldl_phys >>>>> one >>>> >>>> This patch breaks -kernel/-initrd. >>> >>> Breaks it where and when? >> >> x86_64 TCG reboots after the "Probing EDD" step. > > My local build appears to work, qemu-system-x86_64 loads my gentoo linux setup. > I use x86_64 host, gcc 4.4.3, qemu configured with ./configure > --prefix=/inst --target-list=sparc64-softmmu,x86_64-softmmu Normal boot works. Only -kernel/-initrd fails. Paolo