From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33560 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OKSBx-0001ak-8c for qemu-devel@nongnu.org; Fri, 04 Jun 2010 04:23:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OKSBw-000498-4r for qemu-devel@nongnu.org; Fri, 04 Jun 2010 04:23:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55672) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OKSBv-00048x-Tx for qemu-devel@nongnu.org; Fri, 04 Jun 2010 04:23:48 -0400 Message-ID: <4C08B80F.4040401@redhat.com> Date: Fri, 04 Jun 2010 10:23:43 +0200 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code References: <1275583692-11678-1-git-send-email-Jes.Sorensen@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org On 06/04/10 10:21, Markus Armbruster wrote: > Jes.Sorensen@redhat.com writes: >> I have tried to be as careful as I can to not break non Linux support, >> but as I only have a Linux build environment handy, I would appreciate >> it if people with other OSes could check that I didn't break anything >> for them. In particular I would like to know if win32 still builds. > > I like moving stuff out of vl.c in general. Your moves of entire > functions look like a win to me. I have doubts about spreading the > option switch over three files, though. The problem is right now there are too many OS specific options, but having the #ifdefs plastered all over to enable/disable them accordingly is just a nightmare and is prone to leave in inconsistent behavior for various OSes. See the set_proc_name() stuff for an example. Cheers, Jes