From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43784 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OKUOA-0003TO-Q8
	for qemu-devel@nongnu.org; Fri, 04 Jun 2010 06:44:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OKUO9-0003Op-MY
	for qemu-devel@nongnu.org; Fri, 04 Jun 2010 06:44:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:15584)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OKUO9-0003Oi-Er
	for qemu-devel@nongnu.org; Fri, 04 Jun 2010 06:44:33 -0400
Message-ID: <4C08D8D1.1060701@redhat.com>
Date: Fri, 04 Jun 2010 12:43:29 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1275478317-1989-1-git-send-email-armbru@redhat.com>	<1275478317-1989-4-git-send-email-armbru@redhat.com>	<4C067E45.1050801@redhat.com>
	<m36321xvdn.fsf@blackfin.pond.sub.org>
In-Reply-To: <m36321xvdn.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 3/3] blockdev: Collect block device code in
	new blockdev.c
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

Am 02.06.2010 18:16, schrieb Markus Armbruster:
> Kevin Wolf <kwolf@redhat.com> writes:
> 
>> Am 02.06.2010 13:31, schrieb Markus Armbruster:
>>> Anything that moves hundreds of lines out of vl.c can't be all bad.
>>>
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>
>> New files need a license header, otherwise it looks ok.
>>
>> I have applied this patch (and the other ones, too) to the block branch
>> anyway to avoid conflicts with other people basing their patches on that
>> branch. However, it requires a v2 before I can propose this to be merged
>> into master.
> 
> vl.c has "Copyright (c) 2003-2008 Fabrice Bellard".  monitor.c has
> "Copyright (c) 2003-2004 Fabrice Bellard".  Would the following header
> do?
> 
> /*
>  * QEMU host block devices
>  *
>  * Copyright (c) 2003-2008 Fabrice Bellard
>  *
>  * This work is licensed under the terms of the GNU GPL, version 2 or
>  * later.  See the COPYING file in the top-level directory.
>  */

Should be good enough, I think.

vl.c and monitor.c are BSD licensed, though. Not sure if anyone minds if
the license is changed to GPL. Probably not, just want to have it mentioned.

Kevin