From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55195 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OKVYd-0007yw-D7 for qemu-devel@nongnu.org; Fri, 04 Jun 2010 07:59:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OKVYY-0001aY-De for qemu-devel@nongnu.org; Fri, 04 Jun 2010 07:59:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39851) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OKVYY-0001aR-6T for qemu-devel@nongnu.org; Fri, 04 Jun 2010 07:59:22 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o54BxLwL015544 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 4 Jun 2010 07:59:21 -0400 Message-ID: <4C08EA97.4050008@redhat.com> Date: Fri, 04 Jun 2010 13:59:19 +0200 From: Jes Sorensen MIME-Version: 1.0 References: <1275583692-11678-1-git-send-email-Jes.Sorensen@redhat.com> <1275583692-11678-11-git-send-email-Jes.Sorensen@redhat.com> <4C08B797.7060702@redhat.com> <4C08D7EF.4000008@redhat.com> In-Reply-To: <4C08D7EF.4000008@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Markus Armbruster , qemu-devel@nongnu.org On 06/04/10 12:39, Paolo Bonzini wrote: >>> I agree with Richard: this is gross. >> >> The enum creation is gross by itself. Only way to get around not >> duplicating it is to create a new header file to hold just that? > > I don't think it's particularly gross. At least you don't have two > files to keep in sync. > > You could rename qemu-options.h to qemu-options.def, and make a real > header file with the typedef and the enum. Then include the header from > vl.c and os-*.c. I like this idea. I was looking at a qemu-options-somethingelse.h but I couldn't really find any appropriate name for it. Renaming the current qemu-options.h to qemu-options.def seems correct IMHO as it's not really a header file that can be included into code by itself. > BTW from Fedora 11 and newer you can easily build QEMU with a cross > compiler. (Running it is a bit harder). These packages should suffice: > > mingw32-w32api mingw32-cpp mingw32-termcap mingw32-runtime > mingw32-binutils mingw32-filesystem mingw32-SDL mingw32-gcc > mingw32-zlib > > and you need to configure it with "--cross-prefix=i686-pc-mingw32-" > (trailing dash included!). Thanks! I'll have to take a look at this. Cheers, Jes