From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40678 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OKVjt-0006sM-2I
	for qemu-devel@nongnu.org; Fri, 04 Jun 2010 08:11:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OKVjo-0004C4-HY
	for qemu-devel@nongnu.org; Fri, 04 Jun 2010 08:11:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47831)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OKVjo-0004Bm-B1
	for qemu-devel@nongnu.org; Fri, 04 Jun 2010 08:11:00 -0400
Message-ID: <4C08ED4D.80600@redhat.com>
Date: Fri, 04 Jun 2010 14:10:53 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Add exit notifiers.
References: <1275644132-22176-1-git-send-email-kraxel@redhat.com>
	<AANLkTilfa2xQSav4bP0VeuFBvlfYI-BOAsWKXW0gPNc5@mail.gmail.com>
In-Reply-To: <AANLkTilfa2xQSav4bP0VeuFBvlfYI-BOAsWKXW0gPNc5@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org

>> --- a/roms/seabios
>> +++ b/roms/seabios
>> @@ -1 +1 @@
>> -Subproject commit 8f469b9676127ba6bb52609d89ec774e61db0ee1
>> +Subproject commit 7d09d0e3ba11310e973d4302c7fcc3fc2184e04c
>
> This hunk seems unrelated to your commit.

Damn.  Yea.  These seem to creap in now and then, I think when rebasing 
to a new version with new seabios, then carelessly doing 'git commit -a'.

>> +void qemu_add_exit_notifier(Notifier *notify)
>
> Why #ifndef _WIN32?  I think this patch will break _WIN32 builds.

Not intentionally.  Sent fixed version.

cheers,
   Gerd