From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57438 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OKVkl-0007Wb-4z
	for qemu-devel@nongnu.org; Fri, 04 Jun 2010 08:12:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1OKVkj-0004NY-3P
	for qemu-devel@nongnu.org; Fri, 04 Jun 2010 08:11:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63083)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1OKVki-0004NR-T7
	for qemu-devel@nongnu.org; Fri, 04 Jun 2010 08:11:57 -0400
Message-ID: <4C08ED88.9070707@redhat.com>
Date: Fri, 04 Jun 2010 14:11:52 +0200
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument
	handling and move SMB arg to os-posix.c
References: <1275583692-11678-1-git-send-email-Jes.Sorensen@redhat.com>	<1275583692-11678-11-git-send-email-Jes.Sorensen@redhat.com>	<m3fx138b81.fsf@blackfin.pond.sub.org>
	<4C08B797.7060702@redhat.com>
	<m3fx132edp.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3fx132edp.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On 06/04/10 14:04, Markus Armbruster wrote:
> Jes Sorensen <Jes.Sorensen@redhat.com> writes:
> 
>> On 06/04/10 10:15, Markus Armbruster wrote:
>> What do you mean? The real ugh! here is that it was created as a
>> typedef. I can change the function to pass in just the index, but I
>> don't know if we will have cases where the rest is needed.
> 
> Moving stuff out of the vl.c grabbag is cool.  Moving stuff into the
> sysemu.h grabbag is very uncool.

I agree, I have a new version of the patch coming up shortly. I just
want to apply Paolo's idea of moving qemu-options.h around a bit.

>>> Is this minor improvement of vl.c really worth the headaches elsewhere?
>>
>> vl.c as it is today is gross and un-maintainable. This patch gets rid of
>> a lot of the ugly #ifdefs and makes the code easier to read and maintain.
> 
> I'm not arguing against your patch, just trying to help making it even
> better.

I was gathering that, and your input is much appreciated.

Cheers,
Jes