From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43415 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OKWoY-0003Mn-LA
	for qemu-devel@nongnu.org; Fri, 04 Jun 2010 09:20:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1OKWoH-0008AA-7O
	for qemu-devel@nongnu.org; Fri, 04 Jun 2010 09:19:46 -0400
Received: from e31.co.us.ibm.com ([32.97.110.149]:35334)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1OKWoH-00083m-2E
	for qemu-devel@nongnu.org; Fri, 04 Jun 2010 09:19:41 -0400
Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com
	[9.17.195.228])
	by e31.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id o54D8djM028539
	for <qemu-devel@nongnu.org>; Fri, 4 Jun 2010 07:08:39 -0600
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168])
	by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	o54DJ3Ns055212
	for <qemu-devel@nongnu.org>; Fri, 4 Jun 2010 07:19:03 -0600
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1])
	by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id o54DJ2eK030674
	for <qemu-devel@nongnu.org>; Fri, 4 Jun 2010 07:19:03 -0600
Message-ID: <4C08FD45.8000404@linux.vnet.ibm.com>
Date: Fri, 04 Jun 2010 08:19:01 -0500
From: Anthony Liguori <aliguori@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1275657527-26032-1-git-send-email-corentincj@iksaif.net>
	<1275657527-26032-3-git-send-email-corentincj@iksaif.net>
	<17E76748-6C1D-4A9A-8AD2-97AA128C189E@suse.de>
In-Reply-To: <17E76748-6C1D-4A9A-8AD2-97AA128C189E@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/5] vnc: JPEG should be disabled if the
 client don't set tight quality
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Corentin Chary <corentincj@iksaif.net>, Qemu-development List <qemu-devel@nongnu.org>

On 06/04/2010 08:16 AM, Alexander Graf wrote:
> On 04.06.2010, at 15:18, Corentin Chary wrote:
>
>    
>> Disable JPEG compression by default and only enable it if the
>> VNC client has sent the requested quality.
>>
>> Signed-off-by: Corentin Chary<corentincj@iksaif.net>
>> ---
>> vnc.c |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/vnc.c b/vnc.c
>> index ed0e096..9cf38d1 100644
>> --- a/vnc.c
>> +++ b/vnc.c
>> @@ -1644,7 +1644,7 @@ static void set_encodings(VncState *vs, int32_t *encodings, size_t n_encodings)
>>      vs->features = 0;
>>      vs->vnc_encoding = 0;
>>      vs->tight_compression = 9;
>> -    vs->tight_quality = 9;
>> +    vs->tight_quality = -1; /* Lossless by default */
>>      
> So what's the threshold? When do you start to be lossy?
>    

When the client explicitly requests it.

Regards,

Anthony Liguori

> Alex
>
>