From: Paolo Bonzini <pbonzini@redhat.com>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: Avi Kivity <avi@redhat.com>,
Qemu-development List <qemu-devel@nongnu.org>,
Gautham R Shenoy <ego@in.ibm.com>
Subject: Re: [Qemu-devel] Re: [PATCH V3 1/3] qemu: Add qemu-wrappers for pthread_attr_t
Date: Fri, 04 Jun 2010 15:27:24 +0200 [thread overview]
Message-ID: <4C08FF3C.20002@redhat.com> (raw)
In-Reply-To: <AANLkTillerLuqd7wGURjPI1Vb1usyiYHqoCnXs-OtJsJ@mail.gmail.com>
On 06/04/2010 03:19 PM, Corentin Chary wrote:
>>> The point of these wrappers AFAIU is not only to add error_exit, but also
>>> to be portable to Windows in the future.
>>
>> This is historical because the code was largely inspired by glibc's
>> implementation of posix-aio. It doesn't need to be detached and since
>> Corentin wants to be able to join a worker, it makes sense to just avoid
>> detaching and pay the overhead of making the threads joinable.
>
> Actually, I want to know if the queue is empty and if no job are
> currently being processed: all worker are idle or stopped. I don't
> really need pthread_join() for that, since worker can be idle (we
> don't want to always start and stop the thread :) ).
Then it's also fine to have all qemu_threads detached (like in my patch
to create all qemu_threads with blocked signals). I just want to avoid
implementing pthreads one day for qemu-threads-win32.c.
Paolo
next prev parent reply other threads:[~2010-06-04 13:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 8:56 [Qemu-devel] [PATCH V3 0/3] qemu: Make AIO threading framework generic Gautham R Shenoy
2010-06-03 8:56 ` [Qemu-devel] [PATCH V3 1/3] qemu: Add qemu-wrappers for pthread_attr_t Gautham R Shenoy
2010-06-03 12:31 ` [Qemu-devel] " Paolo Bonzini
2010-06-04 13:07 ` Anthony Liguori
2010-06-04 13:19 ` Corentin Chary
2010-06-04 13:27 ` Paolo Bonzini [this message]
2010-06-10 11:12 ` Gautham R Shenoy
2010-06-03 8:56 ` [Qemu-devel] [PATCH V3 2/3] qemu: Generic asynchronous threading framework to offload tasks Gautham R Shenoy
2010-06-03 11:41 ` [Qemu-devel] " Corentin Chary
2010-06-03 12:37 ` Paolo Bonzini
2010-06-04 13:16 ` [Qemu-devel] " Anthony Liguori
2010-06-05 7:03 ` Corentin Chary
2010-06-10 11:37 ` Gautham R Shenoy
2010-06-03 8:56 ` [Qemu-devel] [PATCH V3 3/3] qemu: Convert AIO code to use the generic threading infrastructure Gautham R Shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C08FF3C.20002@redhat.com \
--to=pbonzini@redhat.com \
--cc=avi@redhat.com \
--cc=corentin.chary@gmail.com \
--cc=ego@in.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).