From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36369 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OKXNG-000758-9b for qemu-devel@nongnu.org; Fri, 04 Jun 2010 09:55:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OKXN8-0007hP-IV for qemu-devel@nongnu.org; Fri, 04 Jun 2010 09:55:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52120) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OKXN8-0007hG-BW for qemu-devel@nongnu.org; Fri, 04 Jun 2010 09:55:42 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o54Dtf0n006744 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 4 Jun 2010 09:55:41 -0400 Received: from zweiblum.home.kraxel.org (vpn1-4-214.ams2.redhat.com [10.36.4.214]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o54DtcR1018437 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 4 Jun 2010 09:55:40 -0400 Message-ID: <4C0905DA.6080601@redhat.com> Date: Fri, 04 Jun 2010 15:55:38 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1275659074-4516-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1275659074-4516-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] Fix and simplify gui timer logic. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org On 06/04/10 15:44, Gerd Hoffmann wrote: > Kill nographic timer. Have a global gui_timer instead. Have the gui > timer enabled unconditionally. We need a timer running anyway for mmio > flush, so the whole have-gui-timer-only-when-needed logic is pretty > pointless. It also simplifies displaylisteners coming and going at > runtime, we don't need to care about the timer then as it runs anyway. Oops, scratch that. Doesn't apply cleanly on master due to dependencies on other local patches. /me goes preparing a patch series ... cheers, Gerd