From: Richard Henderson <rth@twiddle.net>
To: Jes.Sorensen@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 11/17] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c
Date: Fri, 04 Jun 2010 08:04:34 -0700 [thread overview]
Message-ID: <4C091602.9080303@twiddle.net> (raw)
In-Reply-To: <1275657882-19268-14-git-send-email-Jes.Sorensen@redhat.com>
On 06/04/2010 06:24 AM, Jes.Sorensen@redhat.com wrote:
> ---
> Makefile.objs | 2 ++
> os-posix.c | 19 +++++++++++++++++++
> os-win32.c | 10 ++++++++++
> sysemu.h | 1 +
> vl.c | 19 +++----------------
> 5 files changed, 35 insertions(+), 16 deletions(-)
Looks like you forgot to git add qemu-options.h with this patch.
Otherwise the entire series looks good to me now.
r~
next prev parent reply other threads:[~2010-06-04 15:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 13:24 [Qemu-devel] [PATCH v2 00/17] clean up vl.c code Jes.Sorensen
2010-06-04 13:24 ` [Qemu-devel] [PATCH 00/17] *** SUBJECT HERE *** Jes.Sorensen
2010-06-04 13:37 ` [Qemu-devel] " Jes Sorensen
2010-06-04 13:24 ` [Qemu-devel] [PATCH 01/17] vl.c: Remove double include of netinet/in.h for Solaris Jes.Sorensen
2010-06-04 13:24 ` Jes.Sorensen
2010-06-04 13:24 ` [Qemu-devel] [PATCH 02/17] Create qemu-os-win32.h and move WIN32 specific declarations there Jes.Sorensen
2010-06-04 13:24 ` [Qemu-devel] [PATCH 03/17] Introduce os-win32.c and move polling functions from vl.c Jes.Sorensen
2010-06-04 13:24 ` [Qemu-devel] [PATCH 04/17] vl.c: Move host_main_loop_wait() to OS specific files Jes.Sorensen
2010-06-04 13:24 ` [Qemu-devel] [PATCH 05/17] Introduce os-posix.c and create os_setup_signal_handling() Jes.Sorensen
2010-06-04 13:24 ` [Qemu-devel] [PATCH 06/17] Move win32 early signal handling setup to os_setup_signal_handling() Jes.Sorensen
2010-06-04 13:24 ` [Qemu-devel] [PATCH 07/17] Rename os_setup_signal_handling() to os_setup_early_signal_handling() Jes.Sorensen
2010-06-04 13:24 ` [Qemu-devel] [PATCH 08/17] Move main signal handler setup to os specificfiles Jes.Sorensen
2010-06-04 13:24 ` [Qemu-devel] [PATCH 09/17] Move find_datadir to OS specific files Jes.Sorensen
2010-06-04 13:24 ` [Qemu-devel] [PATCH 10/17] Rename qemu-options.h to qemu-options.def Jes.Sorensen
2010-06-04 13:24 ` [Qemu-devel] [PATCH 11/17] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c Jes.Sorensen
2010-06-04 15:04 ` Richard Henderson [this message]
2010-06-04 13:24 ` [Qemu-devel] [PATCH 12/17] Move runas handling from vl.c to OS specific files Jes.Sorensen
2010-06-04 13:24 ` [Qemu-devel] [PATCH 13/17] Move chroot handling " Jes.Sorensen
2010-06-04 13:24 ` [Qemu-devel] [PATCH 14/17] Move daemonize " Jes.Sorensen
2010-06-04 13:24 ` [Qemu-devel] [PATCH 15/17] Make os_change_process_uid and os_change_root os-posix.c local Jes.Sorensen
2010-06-04 13:24 ` [Qemu-devel] [PATCH 16/17] Move line-buffering setup to OS specific files Jes.Sorensen
2010-06-04 13:24 ` [Qemu-devel] [PATCH 17/17] Move set_proc_name() " Jes.Sorensen
-- strict thread matches above, loose matches on Subject: below --
2010-06-04 16:08 [Qemu-devel] [PATCH v3 00/17] clean up vl.c code Jes.Sorensen
2010-06-04 16:09 ` [Qemu-devel] [PATCH 11/17] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c Jes.Sorensen
2010-06-10 9:42 [Qemu-devel] [PATCH v4 00/17] clean up vl.c code Jes.Sorensen
2010-06-10 9:42 ` [Qemu-devel] [PATCH 11/17] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c Jes.Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C091602.9080303@twiddle.net \
--to=rth@twiddle.net \
--cc=Jes.Sorensen@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).