From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36566 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OKYl7-0006n0-CP for qemu-devel@nongnu.org; Fri, 04 Jun 2010 11:24:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OKYl3-0006zn-SM for qemu-devel@nongnu.org; Fri, 04 Jun 2010 11:24:32 -0400 Received: from are.twiddle.net ([75.149.56.221]:37706) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OKYl3-0006zH-MG for qemu-devel@nongnu.org; Fri, 04 Jun 2010 11:24:29 -0400 Message-ID: <4C091602.9080303@twiddle.net> Date: Fri, 04 Jun 2010 08:04:34 -0700 From: Richard Henderson MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 11/17] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c References: <1275657882-19268-1-git-send-email-Jes.Sorensen@redhat.com> <1275657882-19268-14-git-send-email-Jes.Sorensen@redhat.com> In-Reply-To: <1275657882-19268-14-git-send-email-Jes.Sorensen@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes.Sorensen@redhat.com Cc: qemu-devel@nongnu.org On 06/04/2010 06:24 AM, Jes.Sorensen@redhat.com wrote: > --- > Makefile.objs | 2 ++ > os-posix.c | 19 +++++++++++++++++++ > os-win32.c | 10 ++++++++++ > sysemu.h | 1 + > vl.c | 19 +++---------------- > 5 files changed, 35 insertions(+), 16 deletions(-) Looks like you forgot to git add qemu-options.h with this patch. Otherwise the entire series looks good to me now. r~