From: Paolo Bonzini <pbonzini@redhat.com>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: Anthony Liguori <aliguori@linux.vnet.ibm.com>,
Alexander Graf <agraf@suse.de>,
Qemu-development List <qemu-devel@nongnu.org>,
Gautham R Shenoy <ego@in.ibm.com>
Subject: [Qemu-devel] Re: [PATCH v2 2/2] vnc: threaded VNC server
Date: Fri, 04 Jun 2010 17:11:14 +0200 [thread overview]
Message-ID: <4C091792.3000806@redhat.com> (raw)
In-Reply-To: <AANLkTim3kqzh5QRkYKHkAkGKYKsRY0euNINFWR5f-VIf@mail.gmail.com>
On 06/04/2010 04:55 PM, Corentin Chary wrote:
> Because it's not in a loop ? Like I said in the cover-letter (but this
> should probably be in a comment here) you can't use multiple worker
> on a single queue because of zlib streams. But if the issue is more a
> style issue than the actual implementation, then I can use a loop and
> an exit flag.
Yes, it's both a style issue and a future-proofing issue. I think it's
better to be boring when it comes to locking. :-)
(The cover letter hasn't arrived yet, so I haven't read it).
Paolo
next prev parent reply other threads:[~2010-06-04 15:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 13:20 [Qemu-devel] [PATCH v2 0/2] Threaded VNC server Corentin Chary
2010-06-04 13:20 ` [Qemu-devel] [PATCH v2 1/2] qemu-thread: add qemu_mutex/cond_destroy and qemu_mutex_exit Corentin Chary
2010-06-04 13:20 ` [Qemu-devel] [PATCH v2 2/2] vnc: threaded VNC server Corentin Chary
2010-06-04 13:25 ` [Qemu-devel] " Alexander Graf
2010-06-04 13:53 ` Corentin Chary
2010-06-04 13:44 ` Alexander Graf
2010-06-05 8:03 ` Corentin Chary
2010-06-06 13:54 ` Avi Kivity
2010-06-06 14:39 ` Corentin Chary
2010-06-07 13:36 ` Paolo Bonzini
2010-06-04 14:41 ` Paolo Bonzini
2010-06-04 14:55 ` Corentin Chary
2010-06-04 15:11 ` Paolo Bonzini [this message]
2010-06-06 14:11 ` [Qemu-devel] " Avi Kivity
2010-06-06 14:48 ` Corentin Chary
2010-06-06 14:53 ` Avi Kivity
2010-06-06 15:16 ` Corentin Chary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C091792.3000806@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=aliguori@linux.vnet.ibm.com \
--cc=corentin.chary@gmail.com \
--cc=ego@in.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).