From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59102 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OKYfj-0004OT-GL
	for qemu-devel@nongnu.org; Fri, 04 Jun 2010 11:19:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1OKYfc-0005rO-0d
	for qemu-devel@nongnu.org; Fri, 04 Jun 2010 11:18:56 -0400
Received: from mail-ww0-f45.google.com ([74.125.82.45]:63304)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1OKYfb-0005rD-Sj
	for qemu-devel@nongnu.org; Fri, 04 Jun 2010 11:18:51 -0400
Received: by wwb13 with SMTP id 13so1027390wwb.4
	for <qemu-devel@nongnu.org>; Fri, 04 Jun 2010 08:18:48 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4C091792.3000806@redhat.com>
Date: Fri, 04 Jun 2010 17:11:14 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1275657620-26226-1-git-send-email-corentincj@iksaif.net>	<1275657620-26226-3-git-send-email-corentincj@iksaif.net>	<4C09108F.4080004@redhat.com>
	<AANLkTim3kqzh5QRkYKHkAkGKYKsRY0euNINFWR5f-VIf@mail.gmail.com>
In-Reply-To: <AANLkTim3kqzh5QRkYKHkAkGKYKsRY0euNINFWR5f-VIf@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2 2/2] vnc: threaded VNC server
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: Anthony Liguori <aliguori@linux.vnet.ibm.com>, Alexander Graf <agraf@suse.de>, Qemu-development List <qemu-devel@nongnu.org>, Gautham R Shenoy <ego@in.ibm.com>

On 06/04/2010 04:55 PM, Corentin Chary wrote:
> Because it's not in a loop ? Like I said in the cover-letter (but this
> should probably be in a comment here) you can't use multiple worker
> on a single queue because of zlib streams. But if the issue is more a
> style issue than the actual implementation, then I can use a loop and
> an exit flag.

Yes, it's both a style issue and a future-proofing issue.  I think it's 
better to be boring when it comes to locking. :-)

(The cover letter hasn't arrived yet, so I haven't read it).

Paolo