From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49149 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OKb2Q-0008FQ-V7 for qemu-devel@nongnu.org; Fri, 04 Jun 2010 13:50:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OKb2M-00056R-3a for qemu-devel@nongnu.org; Fri, 04 Jun 2010 13:50:34 -0400 Received: from are.twiddle.net ([75.149.56.221]:50460) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OKb2L-00056M-UE for qemu-devel@nongnu.org; Fri, 04 Jun 2010 13:50:30 -0400 Message-ID: <4C093CE5.3030503@twiddle.net> Date: Fri, 04 Jun 2010 10:50:29 -0700 From: Richard Henderson MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 00/10] target-mips: add microMIPS ASE support, v2 References: <1274717984-25887-1-git-send-email-froydnj@codesourcery.com> In-Reply-To: <1274717984-25887-1-git-send-email-froydnj@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nathan Froyd Cc: qemu-devel@nongnu.org, aurelien@aurel32.net On 05/24/2010 09:19 AM, Nathan Froyd wrote: > This patch series adds support for the microMIPS ASE. microMIPS is a > new ASE similar to MIPS16, but re-encodes the entire instruction set > into 16-bit and 32-bit instructions--in contrast to MIPS16, which > re-encodes only integer instructions. The mechanisms for going in and > out of microMIPS mode are identical to those for MIPS16; a given chip > cannot support both ASEs simultaneously. The review that follows doesn't include verification of the ASE, as http://www.mips.com/products/product-materials/processor/mips-architecture/ doesn't list Volume IV-g yet. I'm only going to look at style and other possible coding errors. r~