From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=53896 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OKbkg-0008Ea-1l for qemu-devel@nongnu.org; Fri, 04 Jun 2010 14:36:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OKbkb-0004Ok-1F for qemu-devel@nongnu.org; Fri, 04 Jun 2010 14:36:17 -0400 Received: from are.twiddle.net ([75.149.56.221]:49108) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OKbka-0004ON-H2 for qemu-devel@nongnu.org; Fri, 04 Jun 2010 14:36:13 -0400 Message-ID: <4C094799.5020603@twiddle.net> Date: Fri, 04 Jun 2010 11:36:09 -0700 From: Richard Henderson MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 09/10] linux-user: honor low bit of entry PC for MIPS References: <1274717984-25887-1-git-send-email-froydnj@codesourcery.com> <1274717984-25887-10-git-send-email-froydnj@codesourcery.com> In-Reply-To: <1274717984-25887-10-git-send-email-froydnj@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nathan Froyd Cc: qemu-devel@nongnu.org, aurelien@aurel32.net On 05/24/2010 09:19 AM, Nathan Froyd wrote: > Signed-off-by: Nathan Froyd > --- > linux-user/main.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/linux-user/main.c b/linux-user/main.c > index 18b52c0..76d443b 100644 > --- a/linux-user/main.c > +++ b/linux-user/main.c > @@ -3192,7 +3192,9 @@ int main(int argc, char **argv, char **envp) > for(i = 0; i < 32; i++) { > env->active_tc.gpr[i] = regs->regs[i]; > } > - env->active_tc.PC = regs->cp0_epc; > + env->active_tc.PC = regs->cp0_epc & ~(target_ulong)1; > + if (regs->cp0_epc & 1) > + env->hflags |= MIPS_HFLAG_M16; Coding style. r~