From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39065 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OKblT-0000Sj-1N for qemu-devel@nongnu.org; Fri, 04 Jun 2010 14:37:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OKblR-0004ZY-NH for qemu-devel@nongnu.org; Fri, 04 Jun 2010 14:37:06 -0400 Received: from are.twiddle.net ([75.149.56.221]:49112) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OKblQ-0004Z4-Re for qemu-devel@nongnu.org; Fri, 04 Jun 2010 14:37:05 -0400 Message-ID: <4C0947CD.10306@twiddle.net> Date: Fri, 04 Jun 2010 11:37:01 -0700 From: Richard Henderson MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 10/10] hw: honor low bit in mipssim machine References: <1274717984-25887-1-git-send-email-froydnj@codesourcery.com> <1274717984-25887-11-git-send-email-froydnj@codesourcery.com> In-Reply-To: <1274717984-25887-11-git-send-email-froydnj@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nathan Froyd Cc: qemu-devel@nongnu.org, aurelien@aurel32.net On 05/24/2010 09:19 AM, Nathan Froyd wrote: > Signed-off-by: Nathan Froyd > --- > hw/mips_mipssim.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/hw/mips_mipssim.c b/hw/mips_mipssim.c > index a747de5..cd6c2be 100644 > --- a/hw/mips_mipssim.c > +++ b/hw/mips_mipssim.c > @@ -106,7 +106,9 @@ static void main_cpu_reset(void *opaque) > CPUState *env = s->env; > > cpu_reset(env); > - env->active_tc.PC = s->vector; > + env->active_tc.PC = s->vector & ~(target_ulong)1; > + if (s->vector & 1) > + env->hflags |= MIPS_HFLAG_M16; Coding style. r~