From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55829 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OLB90-0003Rr-Ei
	for qemu-devel@nongnu.org; Sun, 06 Jun 2010 04:23:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OLB8y-00068c-Gy
	for qemu-devel@nongnu.org; Sun, 06 Jun 2010 04:23:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:10216)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OLB8y-00068S-98
	for qemu-devel@nongnu.org; Sun, 06 Jun 2010 04:23:44 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o568NgPG003537
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Sun, 6 Jun 2010 04:23:42 -0400
Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com
	[10.35.255.11])
	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id o568NfE0000874
	for <qemu-devel@nongnu.org>; Sun, 6 Jun 2010 04:23:41 -0400
Message-ID: <4C0B5B0C.2090403@redhat.com>
Date: Sun, 06 Jun 2010 11:23:40 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <m34ohryjib.fsf@blackfin.pond.sub.org>
	<m3aarayjbn.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3aarayjbn.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: RFC: blockdev_add & friends, brief rationale,
	QMP docs
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Christoph Hellwig <chellwig@redhat.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>

On 06/04/2010 05:16 PM, Markus Armbruster wrote:
> - "protocol": json-array of json-object
>    Each element object has a member "name"
>      - Possible values: "file", "nbd", ...
>    Additional members depend on the value of "name".
>    For "name" = "file":
>      - "file": file name (json-string)
>    For "name" = "nbd":
>      - "domain": address family (json-string, optional)
>          - Possible values: "inet" (default), "unix"
>      - "file": file name (json-string), only with "domain" = "unix"
>      - "host": host name (json-string), only with "domain" = "inet"
>      - "port": port (json-int), only with "domain" = "inet"
>    ...
>
>    

This loses the nesting that protocols have.  I'd like to see the each 
nested protocol as member of the parent protocol.  Besides the lovely } 
} }s in the json representation, this allows us to have more complicated 
protocols, for example a mirror protocol that has two child protocol 
each specifying a different backing store.

-- 
error compiling committee.c: too many arguments to function