From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56367 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLBu5-0001mY-Dl for qemu-devel@nongnu.org; Sun, 06 Jun 2010 05:12:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OLBu4-0005gl-2I for qemu-devel@nongnu.org; Sun, 06 Jun 2010 05:12:25 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:58127) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLBu3-0005gQ-Md for qemu-devel@nongnu.org; Sun, 06 Jun 2010 05:12:24 -0400 Message-ID: <4C0B6674.7080602@web.de> Date: Sun, 06 Jun 2010 11:12:20 +0200 From: Jan Kiszka MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig4145A077D7A01607FEF051FF" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 00/16] HPET cleanups, fixes, enhancements List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Paul Brook , qemu-devel@nongnu.org, Gleb Natapov , Juan Quintela This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4145A077D7A01607FEF051FF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Blue Swirl wrote: > On Sun, Jun 6, 2010 at 8:10 AM, Jan Kiszka wrote: >> Second round, specifically adressing: >> - IRQMsg framework to refactor existing de-coalescing code >> - RTC IRQ output as GPIO pin (routed depening on HPET or -no-hpet) >> - ISA reservation for RTC IRQ >> >> If discussion around IRQMsg and de-coalescing happens to continue, I >> would suggest to merge patches 1..7 as they are likely uncontroversial= >> and also fix bugs. >=20 > Otherwise everything looks fine to me, but 10 and 11 had minor > problems. Nice work! Thanks for the quick feedback! >=20 > I'd suppose one possible cleanup could be to use the message payload > in place of apic_deliver_irq()? Haven't looked into such things yet, the series is already long enough. :) I could also imagine that we may avoid exporting the APIC MSI functions for HPET use and instead provide a single MSI qemu_irq object, pushing the vector information into the message payload. Jan --------------enig4145A077D7A01607FEF051FF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkwLZnUACgkQitSsb3rl5xRLsACffBYoAMmuwaL8V0X74vlp1nKO eVoAnRwAtRP9koNX/RKU3J54TvEcqK1f =z/uy -----END PGP SIGNATURE----- --------------enig4145A077D7A01607FEF051FF--