From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42959 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OLeUV-0006U8-CY
	for qemu-devel@nongnu.org; Mon, 07 Jun 2010 11:43:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1OLeUU-0007xn-3E
	for qemu-devel@nongnu.org; Mon, 07 Jun 2010 11:43:55 -0400
Received: from mail-wy0-f173.google.com ([74.125.82.173]:54017)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1OLeUT-0007xg-UZ
	for qemu-devel@nongnu.org; Mon, 07 Jun 2010 11:43:54 -0400
Received: by wyb36 with SMTP id 36so2688782wyb.4
	for <qemu-devel@nongnu.org>; Mon, 07 Jun 2010 08:43:53 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4C0D13AE.1070400@redhat.com>
Date: Mon, 07 Jun 2010 17:43:42 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1275921752-29420-1-git-send-email-berrange@redhat.com>
	<1275921752-29420-14-git-send-email-berrange@redhat.com>
In-Reply-To: <1275921752-29420-14-git-send-email-berrange@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 13/19] Add a query-target command to QMP
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org

On 06/07/2010 04:42 PM, Daniel P. Berrange wrote:
> +#ifdef CONFIG_KVM
> +    qlist_append_obj(engines, qobject_from_jsonf("{ 'name': 'kvm' }"));
> +#endif
> +#ifdef CONFIG_XEN
> +    qlist_append_obj(engines, qobject_from_jsonf("{ 'name': 'xen' }"));
> +#endif

I suggest using kvm_available() and xen_available(), so that any 
cut-and-paste typos do not go undetected in the future.

Paolo