From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50989 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OLkJt-0000M9-UZ
	for qemu-devel@nongnu.org; Mon, 07 Jun 2010 17:57:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OLkJs-0007O4-NP
	for qemu-devel@nongnu.org; Mon, 07 Jun 2010 17:57:21 -0400
Received: from mail-iw0-f173.google.com ([209.85.214.173]:41785)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OLkJs-0007Nx-JK
	for qemu-devel@nongnu.org; Mon, 07 Jun 2010 17:57:20 -0400
Received: by iwn41 with SMTP id 41so4044554iwn.4
	for <qemu-devel@nongnu.org>; Mon, 07 Jun 2010 14:57:19 -0700 (PDT)
Message-ID: <4C0D6B35.8080000@codemonkey.ws>
Date: Mon, 07 Jun 2010 16:57:09 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans
References: <20100607150309.GA13369@redhat.com>
	<201006071716.31103.paul@codesourcery.com>
	<20100607161730.GB11177@redhat.com>
	<201006071742.56312.paul@codesourcery.com>
	<4C0D23B5.3050605@codemonkey.ws>
	<20100607192059.GA14490@redhat.com>
	<4C0D5959.5010303@codemonkey.ws>
	<20100607205823.GA14764@redhat.com>
	<4C0D66A2.4050107@codemonkey.ws>
In-Reply-To: <4C0D66A2.4050107@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org

On 06/07/2010 04:37 PM, Anthony Liguori wrote:
> On 06/07/2010 03:58 PM, Michael S. Tsirkin wrote:
>> On Mon, Jun 07, 2010 at 03:40:57PM -0500, Anthony Liguori wrote:
>>> On 06/07/2010 02:21 PM, Michael S. Tsirkin wrote:
>>>> So I see two ways to go forward: switch default value in my patch,
>>>> or disable vlans unconditionally.
>>>>
>>> The problem with disabling vlans unconditionally is that you break -net
>>> socket and -net dump.
>>>
>>> If we can come up with an alternative way to do these things, I'm all
>>> for removing it.
>> Hmm, I'll try to look at supporting -net socket in netdev.
>> Does -net dump do anything that can't be done with tap+tcpdump?
>
> tap+tcpdump requires root privileges (even if you have a tap helper).
>
> Plus tcpdump doesn't help with slirp and -net dump is very useful for 
> debugging slirp.

Of course, you could add this functionality to netdev.  It's arguably 
better there too because then you can debug virtio-net+tap with full 
offload enabled (which you cannot do today).

Regards,

Anthony Liguori