From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60917 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLtbS-0004vy-DY for qemu-devel@nongnu.org; Tue, 08 Jun 2010 03:52:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OLtbQ-0002yn-CL for qemu-devel@nongnu.org; Tue, 08 Jun 2010 03:52:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50815) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLtbQ-0002yD-5h for qemu-devel@nongnu.org; Tue, 08 Jun 2010 03:52:04 -0400 Message-ID: <4C0DF69D.4040306@redhat.com> Date: Tue, 08 Jun 2010 09:51:57 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice References: <1275954730-8196-1-git-send-email-aliguori@us.ibm.com> <1275954730-8196-2-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1275954730-8196-2-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Glauber Costa , qemu-devel@nongnu.org On 06/08/10 01:51, Anthony Liguori wrote: > Right now, if you set a QemuOpts option in a section twice, when you get the > option you'll receive the value that was set the first time. This is less than > ideal because if you're manipulating options in two places like a global config > followed by the command line, you really want the later to override the former. > > This patch fixes this behavior. Note that this reverses the ordering for users which want multiple values (slirp forwarding for example). cheers, Gerd