From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=43179 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLthq-00042O-Ux for qemu-devel@nongnu.org; Tue, 08 Jun 2010 03:58:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OLtho-0003l5-Lc for qemu-devel@nongnu.org; Tue, 08 Jun 2010 03:58:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13594) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLtho-0003ks-Dc for qemu-devel@nongnu.org; Tue, 08 Jun 2010 03:58:40 -0400 Message-ID: <4C0DF81E.6070601@redhat.com> Date: Tue, 08 Jun 2010 09:58:22 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 05/22] machine: pass all init options as a single QemuOpts References: <1275954730-8196-1-git-send-email-aliguori@us.ibm.com> <1275954730-8196-6-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1275954730-8196-6-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Glauber Costa , qemu-devel@nongnu.org On 06/08/10 01:51, Anthony Liguori wrote: > This patch redefines the machine init signature to just take a QemuOpts. It > also passes the machine as the first parameter to allow multiple boards to be > defined with one init function. > +typedef void QEMUMachineInitFunc(QemuOpts *opts); Hmm? Where is the machine parameter? cheers, Gerd