From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35093 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OLuGt-0007nJ-LX
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 04:34:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OLuGi-0008LL-UI
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 04:34:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:29755)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OLuGi-0008Kb-JV
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 04:34:44 -0400
Message-ID: <4C0DF94F.4070504@redhat.com>
Date: Tue, 08 Jun 2010 10:03:27 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 10/22] machine: allow boards to specify
	default values and use it in isapc
References: <1275954730-8196-1-git-send-email-aliguori@us.ibm.com>
	<1275954730-8196-11-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1275954730-8196-11-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Glauber Costa <glommer@redhat.com>, qemu-devel@nongnu.org

>   static QEMUMachine pc_machine = {
>       .name = "pc-0.13",
>       .alias = "pc",
>       .desc = "Standard PC",
> -    .init = pc_init_pci,
> +    .init = pc_init,
>       .max_cpus = 255,
>       .is_default = 1,
>       .opts_desc = pc_opts_desc,
> +    .opts_default = (QemuOptValue[]) {
> +        {
> +            .name  = "acpi",
> +            .value = "on",
> +        },

Should be moved into a separate struct and just referenced as it is 
identical for pc-0.*

cheers,
   Gerd