From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH] Fix regression for "-drive file="
Date: Tue, 08 Jun 2010 10:09:00 +0200 [thread overview]
Message-ID: <4C0DFA9C.4080502@redhat.com> (raw)
In-Reply-To: <m3ocfmrn35.fsf@blackfin.pond.sub.org>
Am 08.06.2010 09:38, schrieb Markus Armbruster:
> Did this fall through the cracks?
Looks like it. Rebased and applied to the block branch.
Kevin
> Markus Armbruster <armbru@redhat.com> writes:
>
>> Empty file used to create an empty drive (no media). Since commit
>> 9dfd7c7a, it's an error: "qemu: could not open disk image : No such
>> file or directory". Older versions of libvirt can choke on this.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> If this goes in, I'll prepare a patch for stable as well.
>>
>> vl.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/vl.c b/vl.c
>> index 85bcc84..78ec1b2 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -1097,7 +1097,7 @@ DriveInfo *drive_init(QemuOpts *opts, void *opaque,
>> case IF_COUNT:
>> abort();
>> }
>> - if (!file) {
>> + if (!file || !*file) {
>> *fatal_error = 0;
>> return NULL;
>> }
>
prev parent reply other threads:[~2010-06-08 8:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 13:36 [Qemu-devel] [PATCH] Fix regression for "-drive file=" Markus Armbruster
2010-06-08 7:38 ` [Qemu-devel] " Markus Armbruster
2010-06-08 8:09 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0DFA9C.4080502@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).