From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52694 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OLts6-0004GZ-8v
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 04:09:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OLts5-0005Ko-1F
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 04:09:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:30317)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OLts4-0005Kg-PE
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 04:09:16 -0400
Received: from int-mx03.intmail.prod.int.phx2.redhat.com
	(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5889FLR029198
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 8 Jun 2010 04:09:15 -0400
Message-ID: <4C0DFA9C.4080502@redhat.com>
Date: Tue, 08 Jun 2010 10:09:00 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH] Fix regression for "-drive file="
References: <m3sk5y4l1t.fsf@blackfin.pond.sub.org>
	<m3ocfmrn35.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3ocfmrn35.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

Am 08.06.2010 09:38, schrieb Markus Armbruster:
> Did this fall through the cracks?

Looks like it. Rebased and applied to the block branch.

Kevin


> Markus Armbruster <armbru@redhat.com> writes:
> 
>> Empty file used to create an empty drive (no media).  Since commit
>> 9dfd7c7a, it's an error: "qemu: could not open disk image : No such
>> file or directory".  Older versions of libvirt can choke on this.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> If this goes in, I'll prepare a patch for stable as well.
>>
>>  vl.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/vl.c b/vl.c
>> index 85bcc84..78ec1b2 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -1097,7 +1097,7 @@ DriveInfo *drive_init(QemuOpts *opts, void *opaque,
>>      case IF_COUNT:
>>          abort();
>>      }
>> -    if (!file) {
>> +    if (!file || !*file) {
>>          *fatal_error = 0;
>>          return NULL;
>>      }
>