* [Qemu-devel] [PATCH] Fix regression for "-drive file="
@ 2010-05-11 13:36 Markus Armbruster
2010-06-08 7:38 ` [Qemu-devel] " Markus Armbruster
0 siblings, 1 reply; 3+ messages in thread
From: Markus Armbruster @ 2010-05-11 13:36 UTC (permalink / raw)
To: qemu-devel
Empty file used to create an empty drive (no media). Since commit
9dfd7c7a, it's an error: "qemu: could not open disk image : No such
file or directory". Older versions of libvirt can choke on this.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
If this goes in, I'll prepare a patch for stable as well.
vl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/vl.c b/vl.c
index 85bcc84..78ec1b2 100644
--- a/vl.c
+++ b/vl.c
@@ -1097,7 +1097,7 @@ DriveInfo *drive_init(QemuOpts *opts, void *opaque,
case IF_COUNT:
abort();
}
- if (!file) {
+ if (!file || !*file) {
*fatal_error = 0;
return NULL;
}
--
1.6.6.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Qemu-devel] Re: [PATCH] Fix regression for "-drive file="
2010-05-11 13:36 [Qemu-devel] [PATCH] Fix regression for "-drive file=" Markus Armbruster
@ 2010-06-08 7:38 ` Markus Armbruster
2010-06-08 8:09 ` Kevin Wolf
0 siblings, 1 reply; 3+ messages in thread
From: Markus Armbruster @ 2010-06-08 7:38 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf
Did this fall through the cracks?
Markus Armbruster <armbru@redhat.com> writes:
> Empty file used to create an empty drive (no media). Since commit
> 9dfd7c7a, it's an error: "qemu: could not open disk image : No such
> file or directory". Older versions of libvirt can choke on this.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> If this goes in, I'll prepare a patch for stable as well.
>
> vl.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 85bcc84..78ec1b2 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1097,7 +1097,7 @@ DriveInfo *drive_init(QemuOpts *opts, void *opaque,
> case IF_COUNT:
> abort();
> }
> - if (!file) {
> + if (!file || !*file) {
> *fatal_error = 0;
> return NULL;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] Re: [PATCH] Fix regression for "-drive file="
2010-06-08 7:38 ` [Qemu-devel] " Markus Armbruster
@ 2010-06-08 8:09 ` Kevin Wolf
0 siblings, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2010-06-08 8:09 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel
Am 08.06.2010 09:38, schrieb Markus Armbruster:
> Did this fall through the cracks?
Looks like it. Rebased and applied to the block branch.
Kevin
> Markus Armbruster <armbru@redhat.com> writes:
>
>> Empty file used to create an empty drive (no media). Since commit
>> 9dfd7c7a, it's an error: "qemu: could not open disk image : No such
>> file or directory". Older versions of libvirt can choke on this.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> If this goes in, I'll prepare a patch for stable as well.
>>
>> vl.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/vl.c b/vl.c
>> index 85bcc84..78ec1b2 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -1097,7 +1097,7 @@ DriveInfo *drive_init(QemuOpts *opts, void *opaque,
>> case IF_COUNT:
>> abort();
>> }
>> - if (!file) {
>> + if (!file || !*file) {
>> *fatal_error = 0;
>> return NULL;
>> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-08 8:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-11 13:36 [Qemu-devel] [PATCH] Fix regression for "-drive file=" Markus Armbruster
2010-06-08 7:38 ` [Qemu-devel] " Markus Armbruster
2010-06-08 8:09 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).