From: Gerd Hoffmann <kraxel@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Mark McLoughlin <markmc@redhat.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: Do we still need the hack to set qdev id from NICInfo.name?
Date: Tue, 08 Jun 2010 11:03:47 +0200 [thread overview]
Message-ID: <4C0E0773.2000306@redhat.com> (raw)
In-Reply-To: <m3mxv5q4tr.fsf@blackfin.pond.sub.org>
> pci_dev = pci_create(bus, devfn, pci_nic_names[i]);
> dev =&pci_dev->qdev;
> if (nd->name)
> dev->id = qemu_strdup(nd->name);
>
> Blatant violation of the DeviceState abstraction. Which even carries a
> comment advising against this:
> Do we still need this? Anybody wanting ID can use -device.
I think it is only used for -net nic,...,name=something. I think this
predates working -device for nics. So, yes, it shouldn't be needed any
more ...
cheers,
Gerd
prev parent reply other threads:[~2010-06-08 9:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 8:57 [Qemu-devel] Do we still need the hack to set qdev id from NICInfo.name? Markus Armbruster
2010-06-08 9:03 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0E0773.2000306@redhat.com \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=markmc@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).