From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42959 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OLuiv-0007Ou-VS
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 05:04:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OLuiu-00073n-Ld
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 05:03:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60859)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OLuiu-00073V-CV
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 05:03:52 -0400
Received: from int-mx08.intmail.prod.int.phx2.redhat.com
	(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5893p8h001323
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 8 Jun 2010 05:03:51 -0400
Message-ID: <4C0E0773.2000306@redhat.com>
Date: Tue, 08 Jun 2010 11:03:47 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <m3mxv5q4tr.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3mxv5q4tr.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: Do we still need the hack to set qdev id from
	NICInfo.name?
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Mark McLoughlin <markmc@redhat.com>, qemu-devel@nongnu.org

>      pci_dev = pci_create(bus, devfn, pci_nic_names[i]);
>      dev =&pci_dev->qdev;
>      if (nd->name)
>          dev->id = qemu_strdup(nd->name);
>
> Blatant violation of the DeviceState abstraction.  Which even carries a
> comment advising against this:

> Do we still need this?  Anybody wanting ID can use -device.

I think it is only used for -net nic,...,name=something.  I think this 
predates working -device for nics.  So, yes, it shouldn't be needed any 
more ...

cheers,
   Gerd