From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44097 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OLyYv-0004oM-QY
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 09:09:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OLyYY-0001Ne-6j
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 09:09:27 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:44993)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OLyYY-0001NY-45
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 09:09:26 -0400
Received: by gyd5 with SMTP id 5so3202069gyd.4
	for <qemu-devel@nongnu.org>; Tue, 08 Jun 2010 06:09:25 -0700 (PDT)
Message-ID: <4C0E4103.4040702@codemonkey.ws>
Date: Tue, 08 Jun 2010 08:09:23 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 10/22] machine: allow boards to specify
	default values and use it in isapc
References: <1275954730-8196-1-git-send-email-aliguori@us.ibm.com>	<1275954730-8196-11-git-send-email-aliguori@us.ibm.com>
	<4C0DF94F.4070504@redhat.com>
In-Reply-To: <4C0DF94F.4070504@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Glauber Costa <glommer@redhat.com>, qemu-devel@nongnu.org

On 06/08/2010 03:03 AM, Gerd Hoffmann wrote:
>>   static QEMUMachine pc_machine = {
>>       .name = "pc-0.13",
>>       .alias = "pc",
>>       .desc = "Standard PC",
>> -    .init = pc_init_pci,
>> +    .init = pc_init,
>>       .max_cpus = 255,
>>       .is_default = 1,
>>       .opts_desc = pc_opts_desc,
>> +    .opts_default = (QemuOptValue[]) {
>> +        {
>> +            .name  = "acpi",
>> +            .value = "on",
>> +        },
>
> Should be moved into a separate struct and just referenced as it is 
> identical for pc-0.*

Would need to be macros because in future patches, things get more 
complicated.  That may be worth it though.

Regards,

Anthony Liguori

> cheers,
>   Gerd
>
>