From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39157 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OLysG-0003uI-Bi
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 09:29:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OLysF-00054u-2d
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 09:29:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59919)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OLysE-00054c-RG
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 09:29:47 -0400
Message-ID: <4C0E45C4.2050109@redhat.com>
Date: Tue, 08 Jun 2010 15:29:40 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 10/22] machine: allow boards to specify
	default values and use it in isapc
References: <1275954730-8196-1-git-send-email-aliguori@us.ibm.com>	<1275954730-8196-11-git-send-email-aliguori@us.ibm.com>
	<4C0DF94F.4070504@redhat.com> <4C0E4103.4040702@codemonkey.ws>
In-Reply-To: <4C0E4103.4040702@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Glauber Costa <glommer@redhat.com>, qemu-devel@nongnu.org

On 06/08/10 15:09, Anthony Liguori wrote:
> On 06/08/2010 03:03 AM, Gerd Hoffmann wrote:
>>> + .opts_default = (QemuOptValue[]) {
>>> + {
>>> + .name = "acpi",
>>> + .value = "on",
>>> + },
>>
>> Should be moved into a separate struct and just referenced as it is
>> identical for pc-0.*
>
> Would need to be macros because in future patches, things get more
> complicated. That may be worth it though.

Well, maybe not.  Later patches add the compat properties to that list, 
which are different for the pc-0.* versions, so you would have to split 
again ...

cheers
   Gerd