From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48683 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OM0WO-0001f4-3I
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 11:15:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OM0WL-0001Cs-Rn
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 11:15:20 -0400
Received: from mail-pz0-f202.google.com ([209.85.222.202]:57521)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OM0WL-0001Ci-M8
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 11:15:17 -0400
Received: by pzk40 with SMTP id 40so1203000pzk.23
	for <qemu-devel@nongnu.org>; Tue, 08 Jun 2010 08:15:16 -0700 (PDT)
Message-ID: <4C0E5E73.30606@codemonkey.ws>
Date: Tue, 08 Jun 2010 10:14:59 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 01/22] QemuOpts: fix a bug in QemuOpts
	when setting an option twice
References: <1275954730-8196-1-git-send-email-aliguori@us.ibm.com>
	<4C0E1C3B.9020701@redhat.com> <4C0E4096.9020705@codemonkey.ws>
	<201006081538.38232.paul@codesourcery.com>
In-Reply-To: <201006081538.38232.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Glauber Costa <glommer@redhat.com>, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

On 06/08/2010 09:38 AM, Paul Brook wrote:
>> The problem I was trying to address can be seen with something like:
>>
>> -drive file=foo.img,if=virtio,file=bar.img
>>
>> You get no error, and foo.img is what gets used.  It's fair to argue
>> this is a silly use case but what I'm trying to achieve is to make it
>> possible to do:
>>
>> -drive file=foo.img,if=virtio,id=bar -drive file=bar.img,id=bar
>>      
> IMO these should both behave consistently. I'd prefer that both of are errors.
>    

It's fairly common that the last specified argument is what's 
respected.  For instance, if you do qemu -m 512M -m 1G, you'll get 1G of 
memory.

Regards,

Anthony Liguori

> Paul
>