From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55441 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OM0ln-0000mC-CW
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 11:31:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OM0li-000474-HN
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 11:31:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23668)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OM0li-00046o-7h
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 11:31:10 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o58FV8tl015112
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 8 Jun 2010 11:31:08 -0400
Message-ID: <4C0E6238.5090308@redhat.com>
Date: Tue, 08 Jun 2010 17:31:04 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <96e6e74c3b7adc90d57e1303cd09d272bc9f7e06.1276010252.git.amit.shah@redhat.com>
In-Reply-To: <96e6e74c3b7adc90d57e1303cd09d272bc9f7e06.1276010252.git.amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] net: Fix hotplug with pci_add
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>, qemu list <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>

On 06/08/10 17:17, Amit Shah wrote:
> The correct model type wasn't getting added when hotplugging nics with
> pci_add.
>
> Testcase: start VM with default nic type. In the qemu_monitor:
>
> (qemu) pci_add auto nic model=virtio
 >
> This results in a nic hot-plug of the same nic type as the default.

Same goes for mac address and vlan btw, most likely for the same reason. 
  I guess your patch handles this too?

cheers,
   Gerd