From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44441 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OM1I8-0007jo-1b for qemu-devel@nongnu.org; Tue, 08 Jun 2010 12:04:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OM1I2-0002TK-Sn for qemu-devel@nongnu.org; Tue, 08 Jun 2010 12:04:39 -0400 Received: from mail-iw0-f173.google.com ([209.85.214.173]:54638) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM1I2-0002TG-Oq for qemu-devel@nongnu.org; Tue, 08 Jun 2010 12:04:34 -0400 Received: by iwn10 with SMTP id 10so669251iwn.4 for ; Tue, 08 Jun 2010 09:04:34 -0700 (PDT) Message-ID: <4C0E6A0C.7060407@codemonkey.ws> Date: Tue, 08 Jun 2010 11:04:28 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice References: <1275954730-8196-1-git-send-email-aliguori@us.ibm.com> <1275954730-8196-2-git-send-email-aliguori@us.ibm.com> <4C0DF69D.4040306@redhat.com> <4C0E1C3B.9020701@redhat.com> <4C0E4096.9020705@codemonkey.ws> <4C0E4952.3040209@redhat.com> <4C0E5F00.30700@codemonkey.ws> <4C0E63A2.7020201@redhat.com> In-Reply-To: <4C0E63A2.7020201@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Paolo Bonzini , Glauber Costa , qemu-devel@nongnu.org On 06/08/2010 10:37 AM, Gerd Hoffmann wrote: >> What'd expect is: >> >> [net "user"] >> guestfwd = .. >> >> I think multiple entry options are probably not a good thing to have. > > We already have them though (-net switch so QemuOpts added them). Yeah, but let's ignore that for the moment. If we didn't have historical baggage, would we prefer the syntax above or do you think there's value in specifying it on separate lines? At this stage, I'm not worried about config file compatibility. If we need to add some special logic to the -net switch to accommodate it's strange behavior, that's okay with me. Regards, Anthony Liguori > cheers, > Gerd