From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55613 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OMFOJ-0008WE-6D
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 03:08:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OMFIP-0004xF-8G
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 03:01:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:5375)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OMFIO-0004x4-Ud
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 03:01:53 -0400
Message-ID: <4C0F3C55.3060600@redhat.com>
Date: Wed, 09 Jun 2010 09:01:41 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 01/22] QemuOpts: fix a bug in QemuOpts
	when setting an option twice
References: <1275954730-8196-1-git-send-email-aliguori@us.ibm.com>	<1275954730-8196-2-git-send-email-aliguori@us.ibm.com>	<4C0DF69D.4040306@redhat.com>
	<4C0E1C3B.9020701@redhat.com> <4C0E4096.9020705@codemonkey.ws>
	<4C0E4952.3040209@redhat.com> <4C0E5F00.30700@codemonkey.ws>
	<4C0E63A2.7020201@redhat.com> <4C0E6A0C.7060407@codemonkey.ws>
In-Reply-To: <4C0E6A0C.7060407@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Glauber Costa <glommer@redhat.com>, qemu-devel@nongnu.org

On 06/08/10 18:04, Anthony Liguori wrote:
> On 06/08/2010 10:37 AM, Gerd Hoffmann wrote:
>>> What'd expect is:
>>>
>>> [net "user"]
>>> guestfwd = <fw1> <fw2> <fw3>..
>>>
>>> I think multiple entry options are probably not a good thing to have.
>>
>> We already have them though (-net switch so QemuOpts added them).
>
> Yeah, but let's ignore that for the moment. If we didn't have historical
> baggage, would we prefer the syntax above or do you think there's value
> in specifying it on separate lines?

guestfwd entries are relatively long, so having them on one line is 
slightly annonying.  I'd tend to have them on separate lines.  But maybe 
it isn't a bad idea to extend the config file syntax to allow being more 
explicit here, like this (borrowed from makefile syntax):

   option := value       assign, overriding any existing value(s)
   option += value       append

Maybe also

   option ?= value       set only in case it isn't set yet.

cheers,
   Gerd